Zhou Zheng Sheng has posted comments on this change.
Change subject: fix TypeError of _eqSplit in vdsClient.py
......................................................................
Patch Set 2:
Shao He, Dan is not against to "if...else". In fact he thinks we do not support
argument written as "X=true" and "X" , we just support "X=true" for arguments.
In this second patch set, you delete "if..else" and append("") to the list as a
workaround to support both "X=true" and "X".
I think if we need to support both, using "if...else" is more readable and more
straight forward then append("") . If we do not want to support "X", we do not
need the append("") neither.
--
To view, visit http://gerrit.ovirt.org/7200
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I98b5573499adaa1b64f8343b445cc16df8f60f3d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Bing Bu Cao <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Xu He Jie <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
