Ayal Baron has posted comments on this change.
Change subject: BZ#844180: Change scsi scan to asynchronous
......................................................................
Patch Set 9: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/iscsi.py
Line 354: processes = []
Line 355: minTimeout = config.getint('irs', 'scsi_rescan_minimal_timeout')
Line 356: maxTimeout = config.getint('irs', 'scsi_rescan_maximal_timeout')
Line 357: for hba in glob.glob(SCAN_PATTERN):
Line 358: cmd = ['echo', '- - -', '|', '/usr/bin/sudo -n','/bin/dd
of=', hba]
This method is run in supervdsm, why do we need sudo at all?
also, why use echo here? can pass it in data as follows:
cmd = [/bin/dd', 'of=', hba]
misc.execCmd(cmd, data='- - -', sync=False)
Line 359: processes.append((hba, misc.execCmd(cmd, sudo=False,
sync=False)))
Line 360: if (minTimeout > maxTimeout or minTimeout < 0):
Line 361: minTimeout = 2
Line 362: maxTimeout = 30
--
To view, visit http://gerrit.ovirt.org/6796
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7665ebaed716f75af4d03ec1b6a9ff9ff5d84853
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Daniel Paikov <[email protected]>
Gerrit-Reviewer: Eduardo <[email protected]>
Gerrit-Reviewer: Haim Ateya <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
