Dan Kenigsberg has posted comments on this change.

Change subject: vmstats: handle known-missing stats
......................................................................


Patch Set 11:

(3 comments)

https://gerrit.ovirt.org/#/c/43777/11/vdsm/virt/vmstats.py
File vdsm/virt/vmstats.py:

Line 150: known
_skip_if_missing_stats


Line 367: vm
v


Line 372: # TODO
explain why ignoring KeyError here is fine.


-- 
To view, visit https://gerrit.ovirt.org/43777
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I04ecbf98d36d576ede3c3cde36586245ea5e4218
Gerrit-PatchSet: 11
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Francesco Romani <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to