Francesco Romani has posted comments on this change. Change subject: vmstats: handle known-missing stats ......................................................................
Patch Set 11: (3 comments) https://gerrit.ovirt.org/#/c/43777/11/vdsm/virt/vmstats.py File vdsm/virt/vmstats.py: Line 315: / interval), Line 316: 'writeRate': str( Line 317: (last_sample['block.%d.wr.bytes' % last_index] - Line 318: first_sample['block.%d.wr.bytes' % first_index]) Line 319: / interval), unrelated Line 320: } Line 321: Line 322: Line 323: def _disk_latency(first_sample, first_index, last_sample, last_index): Line 363: return name_to_idx Line 364: Line 365: Line 366: @contextlib.contextmanager Line 367: def _known_missing_stats(vm): exceptionally bad name, will clash with vm.py. Please rename. Line 368: try: Line 369: yield Line 370: except KeyError: Line 371: if vm.incomingMigrationPending(): Line 368: try: Line 369: yield Line 370: except KeyError: Line 371: if vm.incomingMigrationPending(): Line 372: pass # TODO explain why Line 373: else: -- To view, visit https://gerrit.ovirt.org/43777 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I04ecbf98d36d576ede3c3cde36586245ea5e4218 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
