Dan Kenigsberg has submitted this change and it was merged. Change subject: vmstats: handle known-missing stats ......................................................................
vmstats: handle known-missing stats In some well-known and benign causes, libvirt will not return the complete set of bulk stats. It is dangerous to blindly ignore KeyErrors when some fields are missing, because this can hide other bugs. But it is safe to ignore them in the aforementioned cases. This patch lays down the basic pieces to safely ignore the errors, starting with the first loud and known case: migration destination VM. Backport-To: 3.6 Change-Id: I04ecbf98d36d576ede3c3cde36586245ea5e4218 Signed-off-by: Francesco Romani <[email protected]> Reviewed-on: https://gerrit.ovirt.org/43777 Continuous-Integration: Jenkins CI Reviewed-by: Dan Kenigsberg <[email protected]> --- M tests/vmStatsTests.py M tests/vmTests.py M vdsm/virt/vm.py M vdsm/virt/vmstats.py 4 files changed, 81 insertions(+), 53 deletions(-) Approvals: Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, approved Francesco Romani: Verified -- To view, visit https://gerrit.ovirt.org/43777 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I04ecbf98d36d576ede3c3cde36586245ea5e4218 Gerrit-PatchSet: 16 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: [email protected] _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
