Amit Aviram has posted comments on this change. Change subject: vm.py: State saving in hotunplugDisk. ......................................................................
Patch Set 4: (2 comments) https://gerrit.ovirt.org/#/c/45077/4//COMMIT_MSG Commit Message: Line 12: the disk, otherwise the disk will remain in xmlDesc and be calculated in Line 13: the vm's hash. Line 14: This causes a bug in the engine's VM monitoring: the engine Line 15: gets the same hash as before the disk was unplugged, thus does not Line 16: update the disk's status. > Most likely (Amit can correct me if I'm wrong) because the saveState trigge Right, saveState changing the hash according to libvirt's XMLDesc(). as for the proper fix, it should be done, but maybe in another patch, as this patch targets specific bugs. Line 17: Line 18: Change-Id: I2cf18186cbba33d7e74fd15651ffec3149c98e1d Line 19: Bug-Url:https://bugzilla.redhat.com/1206696 Line 20: Bug-Url: https://bugzilla.redhat.com/1044466 Line 16: update the disk's status. Line 17: Line 18: Change-Id: I2cf18186cbba33d7e74fd15651ffec3149c98e1d Line 19: Bug-Url:https://bugzilla.redhat.com/1206696 Line 20: Bug-Url: https://bugzilla.redhat.com/1044466 > This change looks good, but I don't think it is required for fixing this bu As for 1044466 you are right, it is not related to this fix and will be removed, thanks. As for 1206696: The bug there is that the disk is shown plugged at engine, but actually it is not connected to the VM. when the user is trying to unplug he gets this error message. This patch moves state related actions to be after the device is detached. Among other things, that means that the VM's _devices_hash will be calculated WITHOUT the detached disk as it should. (saveState sets is based on the current dom.XMLDesc) That means that the hash will be changed (as opposed to before), and the VM monitoring at the engine will now notice that the disk is changed, and will update it to be unplugged. -- To view, visit https://gerrit.ovirt.org/45077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2cf18186cbba33d7e74fd15651ffec3149c98e1d Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amit Aviram <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
