Amit Aviram has posted comments on this change. Change subject: vm.py: State saving in hotunplugDisk. ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/45077/5//COMMIT_MSG Commit Message: Line 12: the disk, otherwise the disk will remain in xmlDesc and be calculated in Line 13: the vm's hash. Line 14: This causes a bug in the engine's VM monitoring: the engine Line 15: gets the same hash as before the disk was unplugged, thus does not Line 16: update the disk's status. > The root cause regarding bug 1206696 seems to be not updating domain xml af A disk can be plugged in cases where there is a race between the vm monitoring and hotunpluging. Vm monitoring can be called while the disk is still attached, then the hountplug is performed and succeed, then the vm monitoring will update the device to be plugged again. at the next vm monitoring, and with this patch, the VM's hash will be changed as it should, and this the engine will update the disk to be unplugged as it really is. This patch is for making the VM disk's status to be synced in the engine. Therefor Verification of it was carried out as follows: - Called hotunplug, make vdsm return (aka the operation succeeded) - at the engine side, break on the part where we analyze the return value of vdsm- change it to false (aka, the engine thinks the operation failed) - now the disk's state is plugged at engine, but unplugged at VDSM. after 2-3 seconds the monitoring will take action again and the disk's state will be changed to hotunplug as it should. Line 17: Line 18: Change-Id: I2cf18186cbba33d7e74fd15651ffec3149c98e1d Line 19: Bug-Url:https://bugzilla.redhat.com/1206696 -- To view, visit https://gerrit.ovirt.org/45077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2cf18186cbba33d7e74fd15651ffec3149c98e1d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amit Aviram <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
