Nir Soffer has posted comments on this change. Change subject: vm.py: State saving in hotunplugDisk. ......................................................................
Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/45077/5//COMMIT_MSG Commit Message: Line 12: the disk, otherwise the disk will remain in xmlDesc and be calculated in Line 13: the vm's hash. Line 14: This causes a bug in the engine's VM monitoring: the engine Line 15: gets the same hash as before the disk was unplugged, thus does not Line 16: update the disk's status. > A disk can be plugged in cases where there is a race between the vm monitor Ok, please update the commit message to explain this flow. Please also add note that this fix is only partial because deatchDevice is async, handled in the next patch. Line 17: Line 18: Change-Id: I2cf18186cbba33d7e74fd15651ffec3149c98e1d Line 19: Bug-Url:https://bugzilla.redhat.com/1206696 -- To view, visit https://gerrit.ovirt.org/45077 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2cf18186cbba33d7e74fd15651ffec3149c98e1d Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Amit Aviram <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Amit Aviram <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Liron Aravot <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
