Nir Soffer has posted comments on this change. Change subject: supervdsm: generalize udevTrigger method ......................................................................
Patch Set 7: (4 comments) https://gerrit.ovirt.org/#/c/44767/7/vdsm/supervdsmServer File vdsm/supervdsmServer: Line 281 Line 282 Line 283 Line 284 Line 285 Rename to udevTriggerMultipath, call _udevTrigger with the correct property_match Line 281: def setSafeNetworkConfig(self): Line 282: return setSafeNetworkConfig() Line 283: Line 284: @logDecorator Line 285: def udevTrigger(self, attr_matches=(), property_matches=()): Rename to _udevTrigger Line 286: ''' Line 287: Request device events from the kernel. Line 288: Line 289: Arguments: Line 372: with open(rule_file, "w") as rf: Line 373: self.log.debug("Creating rule %s: %r", rule_file, rule) Line 374: rf.write(rule) Line 375: Line 376: self.udevTrigger() Call _udevTrigger Line 377: Line 378: @logDecorator Line 379: def rmAppropriateIommuGroup(self, iommu_group): Line 380: """ Line 399: else: Line 400: self.log.debug("Removing rule %s", rule_file) Line 401: Line 402: if not error: Line 403: self.udevTrigger() Call _udevTrigger Line 404: Line 405: @logDecorator Line 406: def ksmTune(self, tuningParams): Line 407: ''' -- To view, visit https://gerrit.ovirt.org/44767 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I761305a54c14e8ac8ef9f4204ee5cc5d55cb31b7 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
