Nir Soffer has posted comments on this change. Change subject: supervdsm: generalize udevTrigger method ......................................................................
Patch Set 5: Code-Review+1 The only question is security - should we allow vdsm to trigger anything, or only specific devices. Previously we allowed only /devm/mapper/<guid>. We need to allow also usb devices (bus=usb device=<name>). We hide the generic trigger behind specific triggerMultipathDevice and triggerUSBDevice. What do you think? -- To view, visit https://gerrit.ovirt.org/44767 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I761305a54c14e8ac8ef9f4204ee5cc5d55cb31b7 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: No _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
