Dan Kenigsberg has posted comments on this change. Change subject: supervdsm: generalize udevTrigger method ......................................................................
Patch Set 10: Code-Review-1 (4 comments) https://gerrit.ovirt.org/#/c/44767/10/vdsm/supervdsmServer File vdsm/supervdsmServer: Line 293: that contain attribute name and English: "2-tuples of an attribute and its value" or "A list of attribute-value tuples, expanded like this:" Line 302: . Expects "Similar to attr_matches, it is a list" Line 303: in a similar Line 308: causes cause -- To view, visit https://gerrit.ovirt.org/44767 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I761305a54c14e8ac8ef9f4204ee5cc5d55cb31b7 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Polednik <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
