Martin Sivák has posted comments on this change. Change subject: lib: daemon: cpu affinity support using taskset ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/45738/1//COMMIT_MSG Commit Message: Line 17: We need a patch which is simple to backport down to 3.5, Line 18: so we use taskset just before the start of VDSM. Line 19: Line 20: taskset is part of util-linux, so no additional dependency Line 21: is needed. > Please do not add more options to cpopen - we want to get rid of it when mo Nir, cpopen is currently the only piece of code that we execute every time we start an external process. Using taskset explicitly at all places will make this patch much more complicated. So I would prefer if you accepted the cpopen patch for the time being as it solves a huge issue on huge machines using a simple enough change. Line 22: Line 23: Change-Id: I3f7f68d65eddb5a21afbc3809ea79cd1dee67984 Line 24: Bug-Url: https://bugzilla.redhat.com/1247075 Line 25: Backport-To: 3.6 -- To view, visit https://gerrit.ovirt.org/45738 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f7f68d65eddb5a21afbc3809ea79cd1dee67984 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
