Nir Soffer has posted comments on this change. Change subject: lib: daemon: cpu affinity support using taskset ......................................................................
Patch Set 3: (4 comments) https://gerrit.ovirt.org/#/c/45738/3//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2015-09-03 19:44:46 +0200 Line 4: Commit: Francesco Romani <from...@redhat.com> Line 5: CommitDate: 2015-09-04 17:06:01 +0200 Line 6: Line 7: lib: daemon: cpu affinity support using taskset This looks like a change in the daemon module of the vdsm library, which is not what this change is about. How about "scale: limit cpu usage using cpu-affinity" ? Line 8: Line 9: To improve reduce the impact of the GIL, we want to pin Line 10: VDSM threads to few cores, maybe just one. Line 11: Line 6: Line 7: lib: daemon: cpu affinity support using taskset Line 8: Line 9: To improve reduce the impact of the GIL, we want to pin Line 10: VDSM threads to few cores, maybe just one. I think you should quote the impressing results from the bug here. Line 11: Line 12: The user can configure using vdsm.conf the cpu cores on Line 13: which she or he wants to let VDSM run on. Line 14: If nothing is specified, VDSM behaves as before and uses Line 9: To improve reduce the impact of the GIL, we want to pin Line 10: VDSM threads to few cores, maybe just one. Line 11: Line 12: The user can configure using vdsm.conf the cpu cores on Line 13: which she or he wants to let VDSM run on. which vdsm should run on? Line 14: If nothing is specified, VDSM behaves as before and uses Line 15: any CPU core. Line 16: Line 17: We need a patch which is simple to backport down to 3.5, Line 14: If nothing is specified, VDSM behaves as before and uses Line 15: any CPU core. Line 16: Line 17: We need a patch which is simple to backport down to 3.5, Line 18: so we use taskset just before the start of VDSM. ... to set vdsm cpu affinity, and we start any child process using taskset to remove vdsm's cpu affinity and allow the child process to use any cpu. Line 19: Line 20: taskset is part of util-linux, so no additional dependency Line 21: is needed. Line 22: -- To view, visit https://gerrit.ovirt.org/45738 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f7f68d65eddb5a21afbc3809ea79cd1dee67984 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Adam Litke <ali...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpoled...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <mskri...@redhat.com> Gerrit-Reviewer: Nir Soffer <nsof...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Yaniv Bronhaim <ybron...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
