Francesco Romani has posted comments on this change. Change subject: lib: daemon: cpu affinity support using taskset ......................................................................
Patch Set 3: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/45738/3/lib/vdsm/utils.py File lib/vdsm/utils.py: Line 57: from M2Crypto import SSL Line 58: Line 59: from cpopen import CPopen Line 60: from . import cmdutils Line 61: from . import config unneeded, relic of past revision Line 62: from . import constants Line 63: Line 64: try: Line 65: # If failing to import old code, then try importing the legacy code https://gerrit.ovirt.org/#/c/45738/3/tests/utilsTests.py File tests/utilsTests.py: Line 954: self._noIntrWatchFd(myPipe, isEpoll=False, mask=select.POLLIN) Line 955: proc.join() Line 956: Line 957: Line 958: class SetMainProcessAffinityTests(TestCaseBase): clumsy, could be improved. Maybe moving to cmdutilsTests? Line 959: Line 960: def test_set_affinity_to_main_process(self): Line 961: Line 962: pid = os.getpid() https://gerrit.ovirt.org/#/c/45738/3/vdsm/vdsm File vdsm/vdsm: Line 251: Line 252: Line 253: def _setAffinity(): Line 254: cpu_allowed = config.get('vars', 'cpu_allowed') Line 255: if not cpu_allowed: feels weird to read. Maybe cpu_whitelist? Line 256: return Line 257: Line 258: cpu_mask = cmdutils.cpu_mask_to_bits(cpu_allowed) Line 259: rc, _, stderr = utils.execCmd(cmdutils.taskset([], cpu_mask, -- To view, visit https://gerrit.ovirt.org/45738 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f7f68d65eddb5a21afbc3809ea79cd1dee67984 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <[email protected]> Gerrit-Reviewer: Martin Sivák <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
