Francesco Romani has posted comments on this change. Change subject: ssl: configurable implementation ......................................................................
Patch Set 9: (1 comment) seems OK, but I need more time to process sslutils.py. https://gerrit.ovirt.org/#/c/44494/9/lib/vdsm/sslutils.py File lib/vdsm/sslutils.py: Line 111: sock = socket.create_connection((self.host, self.port), self.timeout) Line 112: if self._tunnel_host: Line 113: self.sock = sock Line 114: self._tunnel() Line 115: # DK added: pass ca_cert to sslsocket What does "DK" mean? (link to past revisions is fine I most likely missed something trivial) Line 116: self.sock = ssl.wrap_socket(sock, self.key_file, self.cert_file, Line 117: ca_certs=self.ca_certs, server_side=False, Line 118: cert_reqs=self.cert_reqs) Line 119: -- To view, visit https://gerrit.ovirt.org/44494 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6501981bbd5276c49731b0d9eba4794286b0f823 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nir Soffer <[email protected]> Gerrit-Reviewer: Piotr Kliczewski <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Simone Tiraboschi <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: Yeela Kaplan <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
