Dan Kenigsberg has posted comments on this change. Change subject: Define network filter on libvirt ......................................................................
Patch Set 5: Looks good to me, approved (1 inline comment) Thanks! .................................................... File vdsm/nwfilter.py Line 30: Defines network filters on libvirt Line 31: """ Line 32: conn = libvirtconnection.get() Line 33: NoMacSpoofingFilter().defineNwFilter(conn) Line 34: conn.close() someone told me that it is not uncommon for conn.close() to fail. we may need to either fix the issue, or swallow it. but let us postpone this to a future patch. Line 35: Line 36: class NwFilter(object): Line 37: """ Line 38: Base class for custom network filters -- To view, visit http://gerrit.ovirt.org/7354 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9f1708385dec6a87bc404e4ab25c4da8ab8a8acc Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Moti Asayag <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Igor Lvovsky <[email protected]> Gerrit-Reviewer: Livnat Peer <[email protected]> Gerrit-Reviewer: Moti Asayag <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
