Moti Asayag has posted comments on this change.
Change subject: Define network filter on libvirt
......................................................................
Patch Set 4: (2 inline comments)
....................................................
File vdsm/nwfilter.py
Line 34: try:
Line 35: NoMacSpoofingFilter().defineNwFilter(conn)
Line 36: finally:
Line 37: try:
Line 38: conn.close()
The error i got is:
"Exception in thread libvirtEventLoop (most likely raised during interpreter
shutdown)"
I so it has no impact on the return value of the program therefore this block
can be removed. (left on the conn.close())
Line 39: except libvirt.libvirtError:
Line 40: pass
Line 41:
Line 42: class NwFilter(object):
Line 66: # is being used by running VMs
Line 67: pass
Line 68:
Line 69: nwFilter = conn.nwfilterDefineXML(self.buildFilterXml())
Line 70: logging.debug("Filter %s was defined" % (nwFilter.name()))
Done
Line 71:
Line 72:
Line 73: class NoMacSpoofingFilter(NwFilter):
Line 74: """
--
To view, visit http://gerrit.ovirt.org/7354
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f1708385dec6a87bc404e4ab25c4da8ab8a8acc
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
