Igor Lvovsky has posted comments on this change.
Change subject: Define network filter on libvirt
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File vdsm/nwfilter.py
Line 59: # Failure might occur when attempting to remove a filter
which
Line 60: # is being used by running VMs
Line 61: pass
Line 62:
Line 63: nwFilter = conn.nwfilterDefineXML(self.buildFilterXml())
Is this will work if filter already defined and you swallowed the exception in
lines above?
Line 64: logging.debug("Filter %s was defined" % nwFilter.name())
Line 65:
Line 66:
Line 67: class NoMacSpoofingFilter(NwFilter):
--
To view, visit http://gerrit.ovirt.org/7354
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9f1708385dec6a87bc404e4ab25c4da8ab8a8acc
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Igor Lvovsky <[email protected]>
Gerrit-Reviewer: Livnat Peer <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
