Bing Bu Cao has posted comments on this change. Change subject: Added an option to create a watchdog device. ......................................................................
Patch Set 2: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/vm.py Line 382: 'path': floppyPath, 'iface': 'fdc', Line 383: 'index': 0, 'truesize': 0}) Line 384: return removables Line 385: Line 386: def _removeRedundantDevices(self, devices): I think removing one device is a really bad idea. Why not report error? And also it is so expensive to add one function here to remove the multiple devices ,but it only happens in this patch case. So if must do that, please move this part to LINE 441. Line 387: counters = 0 Line 388: for dev in self.conf['devices']: Line 389: if (dev['type'] == devices): Line 390: counters += 1 -- To view, visit http://gerrit.ovirt.org/7535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Bing Bu Cao <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Xu He Jie <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
