Michael Burns has posted comments on this change. Change subject: Add an option to create a watchdog device. ......................................................................
Patch Set 8: I would prefer that you didn't submit this (1 inline comment) .................................................... File vdsm/vdsmd.init.in Line 31: RESPAWNPIDFILE=@VDSMRUNDIR@/respawn.pid Line 32: CORE_DUMP_PATH=/var/log/core/core.%p.%t.dump Line 33: DOM_METADATA_BACKUP_DIR=/var/log/vdsm/backup Line 34: CORE_PATTERN=/proc/sys/kernel/core_pattern Line 35: QEMU_DUMP_PATH="/var/lib/vdsm/dump" Any reason we can't send this to /var/log/core? We persist that to /data so it's not in-memory and persists across reboots. The location does exist and would *work*, but you'd be consuming available memory every time this happens and a reboot would wipe the file out. Also worth noting that there is no facility to read or retrieve this dump on ovirt-node Line 36: NEEDED_SERVICES="iscsid multipathd ntpd wdmd sanlock" Line 37: CONFLICTING_SERVICES="libvirt-guests" Line 38: Line 39: LCONF=/etc/libvirt/libvirtd.conf -- To view, visit http://gerrit.ovirt.org/7535 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Adam Litke <[email protected]> Gerrit-Reviewer: Bing Bu Cao <[email protected]> Gerrit-Reviewer: Doron Fediuck <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Michael Burns <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Xu He Jie <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
