Shu Ming has posted comments on this change.
Change subject: Add an option to create a watchdog device.
......................................................................
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/vm.py
Line 426: else:
Line 427: devices = self.getConfDevices()
Line 428:
Line 429: # libvirt only support one watchdog device
Line 430: if len(devices[BALLOON_DEVICES]) > 1:
Do you mean 'devices[WATCHDOG_DEVICES}' instead of 'devices[BALOON_DEVICES]'
here? And the same questions as lines below.
Line 431: raise ValueError("only a single watchdog device is
supported")
Line 432: if len(devices[BALLOON_DEVICES]) == 1:
Line 433: if not 'specParams' in devices[BALLOON_DEVICES][0]:
Line 434: devices[BALLOON_DEVICES][0]['specParams'] = {}
--
To view, visit http://gerrit.ovirt.org/7535
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2b7970a9050ab0279fe03371b9a77692fba30af8
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Bing Bu Cao <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: ShaoHe Feng <[email protected]>
Gerrit-Reviewer: Shu Ming <[email protected]>
Gerrit-Reviewer: Xu He Jie <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
