Francesco Romani has posted comments on this change. Change subject: utils: Add @throttle decorator ......................................................................
Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/47087/1//COMMIT_MSG Commit Message: Line 17: Line 18: * Non-blocking operations: Line 19: where the request returns specified error when semaphore cannot be obtained Line 20: without blocking and in case it is indeed obtained, it has to be released Line 21: manually afterwareds afterwards Line 22: Line 23: Needed for subsequent migration enhancements. Line 24: Wiki: http://www.ovirt.org/Features/Migration_Enhancements Line 25: https://gerrit.ovirt.org/#/c/47087/1/vdsm/virt/utils.py File vdsm/virt/utils.py: Line 128: Line 129: When block=True we will wait to obtain the semaphore and Line 130: release it after wrapped method execution. Line 131: Line 132: When block=False we won't wait to obtain the semaphore and do we have a clear usecase for block=True? Line 133: in case this fails, will return the specified error. If the execution of Line 134: wrapped method succeeds, it is the responsibility of called code to Line 135: release the semaphore (i.e. method is assumed to be async) Line 136: -- To view, visit https://gerrit.ovirt.org/47087 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab4cf387f77a9b720afb7794e27ed54efa0d3e3c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
