Martin Betak has posted comments on this change. Change subject: utils: Add @throttle decorator ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/47087/1/vdsm/virt/utils.py File vdsm/virt/utils.py: Line 128: Line 129: When block=True we will wait to obtain the semaphore and Line 130: release it after wrapped method execution. Line 131: Line 132: When block=False we won't wait to obtain the semaphore and > do we have a clear usecase for block=True? Not to my knowledge. It seemed like it could be useful to make this more general than the particular async flow of migration start, but I'm open to suggestion how generic we want to have this. Line 133: in case this fails, will return the specified error. If the execution of Line 134: wrapped method succeeds, it is the responsibility of called code to Line 135: release the semaphore (i.e. method is assumed to be async) Line 136: -- To view, visit https://gerrit.ovirt.org/47087 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab4cf387f77a9b720afb7794e27ed54efa0d3e3c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
