Martin Betak has posted comments on this change. Change subject: utils: Add @throttle decorator ......................................................................
Patch Set 1: (1 comment) https://gerrit.ovirt.org/#/c/47087/1/vdsm/virt/utils.py File vdsm/virt/utils.py: Line 155: except Exception: Line 156: success = False Line 157: raise Line 158: finally: Line 159: if not success or block: > whoa, I missed this. We must either found a way to *automatically* release I would like to remind that the whole purpose for this decorator is to cleanly solve the complex release on various error conditions. That we have a "leaking" semaphore as you say is the entire purpose of the "Add incoming migration semaphore" feature and since the verb cannot block on migration to complete I see no way around this. Line 160: semaphore.release() Line 161: Line 162: return wrapper Line 163: -- To view, visit https://gerrit.ovirt.org/47087 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab4cf387f77a9b720afb7794e27ed54efa0d3e3c Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Martin Betak <[email protected]> Gerrit-Reviewer: Francesco Romani <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Betak <[email protected]> Gerrit-Reviewer: Vinzenz Feenstra <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
