Ido Barkan has posted comments on this change. Change subject: netinfo: rework reporting of DHCPv4/6 on network devices ......................................................................
Patch Set 9: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/46430/9/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 582: Line 583: return updated_networking Line 584: Line 585: Line 586: def _update_nested_dict(original, replacement): I think this should be implemented a s a straight forward update of a dictionary, and not as a general replacement. if you feel that this involve too 'digging' too deep into the dictionary, you can just pass the parts that need to be updated. netinfo dict is very complex and updating it should be clear to the reader. Line 587: """ Line 588: Use a replacement dict's fields in two ways: if a value is a dictionary, Line 589: update it recursively. Otherwise replace the value (e.g. a string). Line 590: """ -- To view, visit https://gerrit.ovirt.org/46430 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaffdc836f8f64ecdc0a7e37ef50c228032f99696 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
