Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: rework reporting of DHCPv4/6 on network devices
......................................................................
Patch Set 10: Verified+1
I wanted to say that tests finished with the same results as before (i.e. no
regression) but there were problems (probably unrelated but we should know).
FAIL: test_keep_initial_bond_slaves_ip_config
(functional.networkTests.NetworkTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/share/vdsm/tests/functional/networkTests.py", line 221, in wrapper
func(*args, **kwargs)
File "/usr/share/vdsm/tests/testValidation.py", line 105, in wrapper
return f(*args, **kwargs)
File "/usr/share/vdsm/tests/functional/networkTests.py", line 2823, in
test_keep_initial_bond_slaves_ip_config
self.assertIn(IP_ADDRESS_AND_CIDR, ipv4addrs)
AssertionError: '192.0.2.1/24' not found in []
-------------------- >> begin captured logging << --------------------
root: DEBUG: /sbin/ip -4 addr add dev dummy_4fRg1 192.0.2.1/24 (cwd None)
root: DEBUG: SUCCESS: <err> = ''; <rc> = 0
root: DEBUG: /sbin/ip -6 addr add dev dummy_4fRg1 fdb3:84e5:4ff4:55e3::1/64
(cwd None)
root: DEBUG: SUCCESS: <err> = ''; <rc> = 0
root: INFO: Adding bond11({'nics': ['dummy_4fRg1', 'dummy_V2GEM'], 'options':
''})
root: DEBUG: /sbin/ip addr flush dev dummy_4fRg1 scope global (cwd None)
root: DEBUG: SUCCESS: <err> = ''; <rc> = 0
--------------------- >> end captured logging << ---------------------
In a different run, testStaticNetworkConfig((4,)) failed with
FAIL: testStaticNetworkConfig((4,)) (functional.networkTests.NetworkTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/share/vdsm/tests/testlib.py", line 67, in wrapper
return f(self, *args)
File "/usr/share/vdsm/tests/functional/networkTests.py", line 221, in wrapper
func(*args, **kwargs)
File "/usr/share/vdsm/tests/functional/networkTests.py", line 1989, in
testStaticNetworkConfig
self.assertEqual(status, SUCCESS, msg)
AssertionError: 29 != 0
as well as testSetupNetworksAddBondWithManyVlans(True)
FAIL: testSetupNetworksAddBondWithManyVlans(True)
(functional.networkTests.NetworkTest)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/usr/share/vdsm/tests/testlib.py", line 67, in wrapper
return f(self, *args)
File "/usr/share/vdsm/tests/functional/networkTests.py", line 221, in wrapper
func(*args, **kwargs)
File "/usr/share/vdsm/tests/functional/networkTests.py", line 473, in
testSetupNetworksAddBondWithManyVlans
self.assertEqual(status, SUCCESS, msg)
AssertionError: 29 != 0
--
To view, visit https://gerrit.ovirt.org/46430
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaffdc836f8f64ecdc0a7e37ef50c228032f99696
Gerrit-PatchSet: 10
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Ido Barkan <[email protected]>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <[email protected]>
Gerrit-Reviewer: Petr Horáček <[email protected]>
Gerrit-Reviewer: [email protected]
Gerrit-HasComments: No
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
