Ondřej Svoboda has posted comments on this change. Change subject: netinfo: rework reporting of DHCPv4/6 on network devices ......................................................................
Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/46430/10/lib/vdsm/netinfo.py File lib/vdsm/netinfo.py: Line 576: 'dhcpv4': network_info['dhcpv4'], Line 577: 'dhcpv6': network_info['dhcpv6'], Line 578: 'cfg': cfg, Line 579: } Line 580: cfg['BOOTPROTO'] = 'dhcp' if network_info['dhcpv4'] else 'none' > should be also marked with the same comment as in _update_reported_dhcp ? I made an explicit link between the two functions by adding a docstring to the other. If anyone removes 'cfg' in the second one, they will also realize it makes no sense to keep it here. As there is no best place for a comment in this function, I left it as an exercise for the reader to figure out what parts of code should be removed (→ all that deal with 'cfg'). Line 581: break Line 582: Line 583: return updated_networking Line 584: -- To view, visit https://gerrit.ovirt.org/46430 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaffdc836f8f64ecdc0a7e37ef50c228032f99696 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
