Petr Horáček has posted comments on this change. Change subject: net: tests: support iperf3 for performance tests ......................................................................
Patch Set 23: Code-Review-1 (3 comments) https://gerrit.ovirt.org/#/c/46448/23/lib/vdsm/ipwrapper.py File lib/vdsm/ipwrapper.py: Line 596: Line 597: Line 598: def netns_exec(netns_name, command, sync=False): Line 599: netns_command = [_IP_BINARY.cmd, 'netns', 'exec', netns_name] Line 600: if not sync: we prefer positive conditions Line 601: return execCmd(netns_command + command, sync=sync) Line 602: else: Line 603: _execCmd(netns_command + command) Line 604: https://gerrit.ovirt.org/#/c/46448/23/tests/nettestlib.py File tests/nettestlib.py: Line 237: raise SkipTest(message) Line 238: Line 239: Line 240: class IperfServer(object): Line 241: """starts iperf as an async process""" 'Starts ... process.' Line 242: Line 243: def __init__(self, host, network_ns=None): Line 244: """host: the IP address for the server to listen on. Line 245: network_ns: an optional network namespace for the server to run in. Line 249: self._pid = None Line 250: Line 251: def start(self): Line 252: cmd = [_IPERF3_BINARY.cmd, '--server', '--bind', self._bind_to] Line 253: if self._net_ns is not None: positive condition first (or at least less negative) Line 254: p = netns_exec(self._net_ns, cmd) Line 255: else: Line 256: p = execCmd(cmd, sync=False) Line 257: self._pid = p.pid -- To view, visit https://gerrit.ovirt.org/46448 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15657f8844d131c5444dd680b8de7aa1c4ec2638 Gerrit-PatchSet: 23 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com> Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com> Gerrit-Reviewer: Petr Horáček <phora...@redhat.com> Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
