Ido Barkan has posted comments on this change.

Change subject: net: tests: support iperf3 for performance tests
......................................................................


Patch Set 20:

(2 comments)

https://gerrit.ovirt.org/#/c/46448/20/tests/nettestlib.py
File tests/nettestlib.py:

Line 286: self.error
> I can see IperfClient.out used in the next patch.
Done


Line 290: Investigate, understand
> I'll be grateful if you do! Routes not (dis)appearing in time used to bothe
I am not sure if this anymore. I know that without this code, the test fails on 
this error, but it seems that 'No route to host' does not mean always a routing 
problem. Anyway, this test will not tun in the CI anyway, and is kept as a 
proof for future developers that what we do actually works.


-- 
To view, visit https://gerrit.ovirt.org/46448
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15657f8844d131c5444dd680b8de7aa1c4ec2638
Gerrit-PatchSet: 20
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibar...@redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <dan...@redhat.com>
Gerrit-Reviewer: Ido Barkan <ibar...@redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvob...@redhat.com>
Gerrit-Reviewer: Petr Horáček <phora...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-HasComments: Yes
_______________________________________________
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to