Ondřej Svoboda has posted comments on this change. Change subject: net: tests: support iperf3 for performance tests ......................................................................
Patch Set 20: (1 comment) https://gerrit.ovirt.org/#/c/46448/20/tests/nettestlib.py File tests/nettestlib.py: Line 286: self.error > The usage of the public property (defined below, so I had to find it first) I can see IperfClient.out used in the next patch. Still, I'd like to see self.error replaced with self.out['error'] unless the property has any other immediate use. -- To view, visit https://gerrit.ovirt.org/46448 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I15657f8844d131c5444dd680b8de7aa1c4ec2638 Gerrit-PatchSet: 20 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Ido Barkan <[email protected]> Gerrit-Reviewer: Dan Kenigsberg <[email protected]> Gerrit-Reviewer: Ido Barkan <[email protected]> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ondřej Svoboda <[email protected]> Gerrit-Reviewer: Petr Horáček <[email protected]> Gerrit-Reviewer: [email protected] Gerrit-HasComments: Yes _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
