Adam Litke has posted comments on this change.
Change subject: Added gluster tag support in getAllTasks()
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/storage/taskManager.py
Line 193: elif 'gluster' in tag:
Line 194: subRes.update(self._getAllGlusterTasks())
Line 195: except ge.GlusterException:
Line 196: self.log.error("gluster exception occured", exc_info=True)
Line 197:
I wouldn't say it's good. It's really just a hack. Rather than continuing to
add special case code all over taskManager for gluster tasks we should fix it
properly. It's only going to get harder the longer we keep adding band-aids.
Line 198: self.log.debug("Return: %s", subRes)
Line 199: return subRes
Line 200:
Line 201: def unloadTasks(self, tag=None):
--
To view, visit http://gerrit.ovirt.org/7579
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c765cbfebb5ba22f0d21efa04c824ea4daf6432
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Timothy Asir <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
