Dan Kenigsberg has posted comments on this change.
Change subject: Added gluster tag support in getAllTasks()
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File vdsm/storage/taskManager.py
Line 113: taskID)
Line 114: self.log.debug("Return: %s", subRes)
Line 115: return subRes
Line 116:
Line 117: def getAllTasks(self, tag=[]):
I'm all for having a set of tags. However, the current code is a mess, since it
stores multiple tags as space-separated string, and does an in-string search
instead of a proper set membership.
starting to rely on this before fixing it is going to be troublesome.
Line 118: """
Line 119: Return Tasks for all public tasks if param tag is empty,
Line 120: else return tasks those tags are in param tag.
Line 121: """
--
To view, visit http://gerrit.ovirt.org/7579
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c765cbfebb5ba22f0d21efa04c824ea4daf6432
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Timothy Asir <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
