Adam Litke has posted comments on this change.
Change subject: Added gluster tag support in getAllTasks()
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/storage/taskManager.py
Line 24
Line 25
Line 26
Line 27
Line 28
I still do not like this scope creep into taskManager. If you need custom
logic for gluster tasks then that should be moved into a separate file
'glusterTasks.py' with an appropriate interface. All of this glusterEnabled
cruft should be hidden inside that gluster-specific module.
Line 144: elif 'gluster' in tag:
Line 145: subRes.update(GlusterApi.getTasks())
Line 146: except ge.GlusterException:
Line 147: self.log.error("gluster exception occured",
exc_info=True)
Line 148:
Once you have a glusterTasks.py you can:
gTasks = glusterTasks.getTasks(tag)
subres.update(gTasks)
This module should not be dealing with whether or not gluster is enabled. It
should also not be directly handling GlusterException
Line 149: self.log.debug("Return: %s", subRes)
Line 150: return subRes
Line 151:
Line 152: def unloadTasks(self, tag=None):
--
To view, visit http://gerrit.ovirt.org/7579
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I9c765cbfebb5ba22f0d21efa04c824ea4daf6432
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Bala.FA <[email protected]>
Gerrit-Reviewer: Adam Litke <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Bala.FA <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Timothy Asir <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
