Dan Kenigsberg has posted comments on this change.
Change subject: converting some more RH strings to oVirt
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/libvirtvm.py
Line 662: m.setAttribute('name', k)
Line 663: m.appendChild(self.doc.createTextNode(v))
Line 664: syselem.appendChild(m)
Line 665:
Line 666: appendEntry('manufacturer', 'oVirt')
Please be kind to downstream, and make this a configurable "macro".
Line 667: appendEntry('product', osname)
Line 668: appendEntry('version', osversion)
Line 669: appendEntry('serial', hostUUID)
Line 670: appendEntry('uuid', self.conf['vmId'])
Line 1218: domxml.appendOs()
Line 1219:
Line 1220: osd = caps.osversion()
Line 1221: domxml.appendSysinfo(
Line 1222: osname=caps.getos(),
it is great to be generic, and dropping the RH trademark is important, but let
us not break downstream functionality. Downstream installed base expects the
constant RHEVH string (something about guest rhn).
Line 1223: osversion=osd.get('version', '') + '-' +
osd.get('release', ''),
Line 1224: hostUUID=utils.getHostUUID())
Line 1225:
Line 1226: domxml.appendClock()
--
To view, visit http://gerrit.ovirt.org/7841
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d9a401e93cedc8e07b3f3e14ad523d00e9f0f94
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
