Peter V. Saveliev has posted comments on this change.
Change subject: converting some more RH strings to oVirt
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vdsm/libvirtvm.py
Line 664: m.setAttribute('name', k)
Line 665: m.appendChild(self.doc.createTextNode(v))
Line 666: syselem.appendChild(m)
Line 667:
Line 668: if osname == caps.OSName.RHEL
does it pass syntax check?
Line 669: osname = caps.OSName.RHEVH
Line 670:
Line 671: appendEntry('manufacturer', _SMBIOS_MANUFACTURER)
Line 672: appendEntry('product', osname)
Line 665: m.appendChild(self.doc.createTextNode(v))
Line 666: syselem.appendChild(m)
Line 667:
Line 668: if osname == caps.OSName.RHEL
Line 669: osname = caps.OSName.RHEVH
tabs?
Line 670:
Line 671: appendEntry('manufacturer', _SMBIOS_MANUFACTURER)
Line 672: appendEntry('product', osname)
Line 673: appendEntry('version', osversion)
--
To view, visit http://gerrit.ovirt.org/7841
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d9a401e93cedc8e07b3f3e14ad523d00e9f0f94
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
