Dan Kenigsberg has posted comments on this change.
Change subject: converting some more RH strings to oVirt
......................................................................
Patch Set 5: (2 inline comments)
....................................................
File vdsm/libvirtvm.py
Line 41: # This device name is used as default both in the qemu-guest-agent
Line 42: # service/daemon and in libvirtd (to be used with the quiesce flag).
Line 43: _QEMU_GA_DEVICE_NAME = 'org.qemu.guest_agent.0'
Line 44:
Line 45: _SMBIOS_MANUFACTURER = 'oVirt'
it could be nicer to put this as a configure.ac macro. just below ENGINE name.
this way we would not forget to unfix this downstream.
However, if you promise to be responsible for this during next rebase, I can
this patch as it is.
Line 46:
Line 47:
Line 48: class MERGESTATUS:
Line 49: NOT_STARTED = "Not Started"
Line 663: m = self.doc.createElement('entry')
Line 664: m.setAttribute('name', k)
Line 665: m.appendChild(self.doc.createTextNode(v))
Line 666: syselem.appendChild(m)
Line 667:
confusing!
Line 668: if osname == caps.OSName.RHEL:
Line 669: osname = caps.OSName.RHEVH
Line 670:
Line 671: appendEntry('manufacturer', _SMBIOS_MANUFACTURER)
--
To view, visit http://gerrit.ovirt.org/7841
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0d9a401e93cedc8e07b3f3e14ad523d00e9f0f94
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Antoni Segura Puimedon <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Peter V. Saveliev <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
