Alon Bar-Lev has posted comments on this change.
Change subject: vdsm bootstrap changes for kvm on ppc64 support
......................................................................
Patch Set 4: (8 inline comments)
OK...
Gave up.
Please submit new patch without syntax and unrelated cleanups. Or submit a
separate patch for the cleanups then the ppc.
Thanks!
....................................................
File vds_bootstrap/vds_bootstrap.py
Line 56:
Line 57: try:
Line 58: LOGDIR = os.environ["OVIRT_LOGDIR"]
Line 59: except KeyError:
Line 60: LOGDIR = tempfile.gettempdir()
please don't cleanup within patch.
Line 61: logging.basicConfig(level=logging.DEBUG,
Line 62: format='%(asctime)s %(levelname)-8s %(module)s '
Line 63: '%(lineno)d %(message)s',
Line 64: datefmt='%a, %d %b %Y %H:%M:%S',
Line 91: REQ_PACK = ('SDL', 'bridge-utils', 'mesa-libGLU', 'openssl', 'rsync')
Line 92:
Line 93: if rhel6based:
Line 94: DEVEL_PACK = ()
Line 95: VDS_PACK = ('qemu-kvm', 'qemu-kvm-tools', VDSM_NAME, VDSM_NAME +
'-cli',
please don't cleanup...
Line 96: 'libjpeg', 'spice-server', 'pixman',
Line 97: 'seabios', 'qemu-img', 'fence-agents',
Line 98: 'libselinux-python', 'sanlock', 'sanlock-python')
Line 99: # Gluster packages
Line 102: else:
Line 103: # Devel packages
Line 104: DEVEL_PACK = ('gdb', 'tcpdump', 'strace', 'ltrace', 'sysstat',
'ntp',
Line 105: 'pstack', 'vim-common', 'vim-enhanced',
Line 106: 'systemtap', 'systemtap-runtime')
please don't cleanup...
Line 107: # VDS packages
Line 108: VDS_PACK = ('kvm', 'kmod-kvm', 'kvm-tools', VDSM_NAME, VDSM_NAME
+ '-cli', 'qcairo',
Line 109: 'qffmpeg-libs', 'qspice-libs', 'qpixman', 'log4cpp',
Line 110: 'etherboot-zroms-kvm', 'kvm-qemu-img', 'fence-agents')
Line 102
Line 103
Line 104
Line 105
Line 106
cleanup in different patch.
Line 431: if self.res == "WARN":
Line 432: self.req_pack.append(pack_arch)
Line 433:
Line 434: for p in self.req_pack:
Line 435: logging.debug('>>> %s should be installed', p)
please don't cleanup.
Line 436: logging.debug('Check VDS packages ...')
Line 437: for pack in VDS_PACK:
Line 438: self.res, self.message = deployUtil.getPackageInfo("VDS",
pack, 'status')
Line 439: self._xmlOutput('VDS PACKAGES', self.res, "result", pack,
self.message)
Line 440: if self.res == "WARN":
Line 441: self.vds_pack.append(pack)
Line 442:
Line 443: for p in self.vds_pack:
Line 444: logging.debug('>>> %s should be installed', p)
please don't cleanup.
Line 445: logging.debug('Check development packages ...')
Line 446: for pack in DEVEL_PACK:
Line 447: self.res, self.message =
deployUtil.getPackageInfo("DEVEL", pack, 'status')
Line 448: self._xmlOutput('DEVEL PACKAGES', self.res, "result",
pack, self.message)
Line 443
Line 444
Line 445
Line 446
Line 447
please don't cleanup.
Line 483: res = "OK"
Line 484: if not self.res:
Line 485: res = "FAIL"
Line 486: nReturn = 1
Line 487: self._xmlOutput(type + ' PACKAGES', res, "result", pack,
please don't cleanup.
Line 488: self.message)
Line 489: else:
Line 490: nReturn = 1
Line 491: logging.debug('Unknown package type: %s', type)
--
To view, visit http://gerrit.ovirt.org/7072
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I06ca5dc3adba6183657afed778f999715ee332e0
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Pradipta Banerjee <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
