Alon Bar-Lev has posted comments on this change.
Change subject: vdsm bootstrap changes for kvm on ppc64 support
......................................................................
Patch Set 5: (4 inline comments)
....................................................
File vds_bootstrap/vds_bootstrap.py
Line 73:
Line 74: if (deployUtil.getOSName() == "fedora") and (deployUtil.getOSVersion()
>= "16"):
Line 75: fedorabased = True
Line 76:
Line 77: logging.debug("fedorabased=%d rhel6based=%d/>", fedorabased,
rhel6based)
/> ?
Line 78:
Line 79: if rhel6based:
Line 80: VDSM_NAME = "vdsm"
Line 81: VDSM_MIN_VER = "4.9"
Line 300: self.res = "Intel"
Line 301: elif "AuthenticAMD" == deployUtil.cpuVendorID():
Line 302: self.res = "AMD"
Line 303: else:
Line 304: self.res = "IBM"
Can't we detect this and not use it as default?
Line 305:
Line 306: if self.vt_svm is None:
Line 307: self.vt_svm = "NA"
Line 308:
Line 395: self.rc = 0
Line 396:
Line 397: def _avoidPKGConflict(self):
Line 398: arch = deployUtil.getPlatformArch()
Line 399: for pack in CONFL_PACK:
I would prefer you rename the pack to pack_prefix and leave the pack variable
to be used within loop...
Line 400: pack_arch = pack + "." + arch
Line 401: self.res, self.message =
deployUtil.getPackageInfo("CONFL", pack_arch, 'status')
Line 402: res = self.res #Reverse display status
Line 403: if res == "WARN":
....................................................
File vdsm_reg/deployUtil.py.in
Line 1425: elif vendor == 'AuthenticAMD':
Line 1426: bios_en = _svm_enabled_by_bios();
Line 1427: has_cpu = _cpu_has_svm_support();
Line 1428: elif vendor == 'IBM_POWER':
Line 1429: if (_check_kvm_support_on_power()):
no need for ()...
Line 1430: bios_en = 1;
Line 1431: has_cpu = 1;
Line 1432: else:
Line 1433: return False
--
To view, visit http://gerrit.ovirt.org/7072
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I06ca5dc3adba6183657afed778f999715ee332e0
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Pradipta Banerjee <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
