Alon Bar-Lev has posted comments on this change.
Change subject: vdsm bootstrap changes for kvm on ppc64 support
......................................................................
Patch Set 6: (3 inline comments)
....................................................
File vds_bootstrap/vds_bootstrap.py
Line 300: self.res = "Intel"
Line 301: elif "AuthenticAMD" == deployUtil.cpuVendorID():
Line 302: self.res = "AMD"
Line 303: elif "IBM_POWER" == deployUtil.cpuVendorID():
Line 304: self.res = "IBM"
No... I think we should fail with error...
What do you think?
Line 305:
Line 306: if self.vt_svm is None:
Line 307: self.vt_svm = "NA"
Line 308:
....................................................
File vdsm_reg/deployUtil.py.in
Line 321:
Line 322: if ret == 0 and "Not" not in out: #Avoid error string- 'Not
Settable' or 'Not Present'
Line 323: strReturn = out.replace ("\n", "")
Line 324: elif getPlatformArch() == "ppc64":
Line 325: if os.path.exists('/proc/device-tree/system-id'):
Hmm....
I think it should:
logging.error("getMachineUUID: Could not find machine's UUID.")
Line 326: strReturn =
file('/proc/device-tree/system-id').readline().replace(",","")
Line 327: else:
Line 328: logging.error("getMachineUUID: Could not find machine's
UUID.")
Line 329:
Line 322: if ret == 0 and "Not" not in out: #Avoid error string- 'Not
Settable' or 'Not Present'
Line 323: strReturn = out.replace ("\n", "")
Line 324: elif getPlatformArch() == "ppc64":
Line 325: if os.path.exists('/proc/device-tree/system-id'):
Line 326: strReturn =
file('/proc/device-tree/system-id').readline().replace(",","")
OK. This will be fine, I need to change this id format anyway.
Line 327: else:
Line 328: logging.error("getMachineUUID: Could not find machine's
UUID.")
Line 329:
Line 330: return strReturn
--
To view, visit http://gerrit.ovirt.org/7072
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I06ca5dc3adba6183657afed778f999715ee332e0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Pradipta Banerjee <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Douglas Schilling Landgraf <[email protected]>
Gerrit-Reviewer: Itamar Heim <[email protected]>
Gerrit-Reviewer: Pradipta Banerjee <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
