Zhou Zheng Sheng has posted comments on this change. Change subject: fix dataProgress of migration ......................................................................
Patch Set 1: I would prefer that you didn't submit this (2 inline comments) Please explain why calculation for memProgress is not modified according to your theory. .................................................... File vdsm/libvirtvm.py Line 356: Line 357: while not self._stop.isSet(): Line 358: self._stop.wait(self._MIGRATION_MONITOR_INTERVAL) Line 359: (jobType, timeElapsed, _, Line 360: dataTotal, dataProcessed, dataRemaining, I think it can be memTotal, memProcessed, memRemaining, Line 361: memTotal, memProcessed, _, Line 362: fileTotal, fileProcessed, _) = self._vm._dom.jobInfo() Line 363: Line 364: if (smallest_dataRemaining is None or Line 379: continue Line 380: Line 381: dataProgress = (100 - 100 * dataRemaining) / dataTotal \ Line 382: if dataTotal else 0 Line 383: memProgress = 100 * memProcessed / memTotal if memTotal else 0 If "memRemaining" has been assigned a value in line 361, it can be used here. So the "memProgress" calculation methoed can be rewritten according to your theory as well. Line 384: Line 385: self._vm.log.info( Line 386: 'Migration Progress: %s seconds elapsed, ' Line 387: '%s%% of data processed, %s%% of mem processed' -- To view, visit http://gerrit.ovirt.org/7914 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ff16da7a0bfb6a28cb8bae6b127bff46575d5f6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Xu He Jie <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
