Zhou Zheng Sheng has posted comments on this change. Change subject: fix dataProgress of migration ......................................................................
Patch Set 1: I did not conduct an experiment. I just read the related code you mentioned. It seems you are right. If memTotal is the amount of the total guest memory but not the amount of the memory to dump, to use memRemaining is more accurate. I read virDomainGetJobInfo and struct virDomainJobInfo documentation on offcial web site of libvirt. There is no detail information on the members memProcessed and memTotal, so I read the code. In include/libvirt/libvirt.h, it says * For VIR_DOMAIN_JOB_UNBOUNDED, dataTotal may be less * than the final sum of dataProcessed + dataRemaining * in the event that the hypervisor has to repeat some * data eg due to dirtied pages during migration * * For VIR_DOMAIN_JOB_BOUNDED, dataTotal shall always * equal sum of dataProcessed + dataRemaining So it's obvious if we are doing VIR_DOMAIN_JOB_UNBOUNDED, using dataProcessed to calculate the progress is misleading. If the data actually processed is small, the progress can not reach 100%, if there are a lot of dirty pages, the progress can exceed 100%. In summary, your idea is good. However in the patch, I notice you change the way of calculating dataProgress, but not memProgress. Why do not change the memProgress calculation michanism? -- To view, visit http://gerrit.ovirt.org/7914 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ff16da7a0bfb6a28cb8bae6b127bff46575d5f6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Xu He Jie <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
