Michal Skrivanek has posted comments on this change. Change subject: fix dataProgress of migration ......................................................................
Patch Set 3: (1 inline comment) one minor comment to fix, please .................................................... File vdsm/libvirtvm.py Line 377: Line 378: if jobType == 0: Line 379: continue Line 380: Line 381: dataProgress = 100 - 100 * dataRemaining / dataTotal \ well, if you look at virsh-domain.c they're also handling a case when you have dataRemaining << dataTotal, i.e. dataProgress would evaluate to 100(rounded) but there's still some few bytes left Line 382: if dataTotal else 0 Line 383: memProgress = 100 - 100 * memRemaining / memTotal \ Line 384: if memTotal else 0 Line 385: -- To view, visit http://gerrit.ovirt.org/7914 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ff16da7a0bfb6a28cb8bae6b127bff46575d5f6 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Gal Hammer <[email protected]> Gerrit-Reviewer: Mark Wu <[email protected]> Gerrit-Reviewer: Michal Skrivanek <[email protected]> Gerrit-Reviewer: ShaoHe Feng <[email protected]> Gerrit-Reviewer: Shu Ming <[email protected]> Gerrit-Reviewer: Xu He Jie <[email protected]> Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
