Federico Simoncelli has posted comments on this change.
Change subject: DomainMonitor shouldn't releaseHostId if the domain is missing
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File vdsm/storage/domainMonitor.py
Line 150: self.log.debug("Stopping domain monitor for %s", self.sdUUID)
Line 151:
Line 152: # If this is an ISO domain we didn't acquire the host id and
releasing
Line 153: # it is superfluous.
Line 154: if self.domain and not self.isIsoDomain:
Nothing is ever setting self.domain back to None. What might happen is that the
domain disappears (but you still hold the proxy), there's no way (or reason) to
protect against that.
Line 155: try:
Line 156: self.domain.releaseHostId(self.hostId, unused=True)
Line 157: except:
Line 158: self.log.debug("Unable to release the host id %s for
domain "
--
To view, visit http://gerrit.ovirt.org/7833
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b2d97f95d682ea00079cee0c0587243ed56651c
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
