Ayal Baron has posted comments on this change.
Change subject: DomainMonitor shouldn't releaseHostId if the domain is missing
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/storage/domainMonitor.py
Line 149: self.log.debug("Stopping domain monitor for %s", self.sdUUID)
Line 150:
Line 151: # If this is an ISO domain we didn't acquire the host id and
releasing
Line 152: # it is superfluous.
Line 153: if self.domain and not self.isIsoDomain:
shouldn't we release the host id even if we lost the domain object? i.e.
shouldn't we cache the info needed on the monitor object to be able to release
even if domain is inaccessible (of course sanlock would not be able to write
anything, but at least we'd stop the fencing if relevant).
Line 154: try:
Line 155: self.domain.releaseHostId(self.hostId, unused=True)
Line 156: except:
Line 157: self.log.debug("Unable to release the host id %s for
domain "
--
To view, visit http://gerrit.ovirt.org/7833
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b2d97f95d682ea00079cee0c0587243ed56651c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
