Federico Simoncelli has posted comments on this change.
Change subject: domain: releaseHostId only when the domain is present
......................................................................
Patch Set 2: (1 inline comment)
....................................................
File vdsm/storage/domainMonitor.py
Line 149: self.log.debug("Stopping domain monitor for %s", self.sdUUID)
Line 150:
Line 151: # If this is an ISO domain we didn't acquire the host id and
releasing
Line 152: # it is superfluous.
Line 153: if self.domain and not self.isIsoDomain:
No, the thing that triggers the fencing are the resources, not the host id. You
can safely lose an host id if you have no resources on it (no countermeasure
are taken). In the future the VM's resources are handled by libvirt anyway
(pause) and the SPM goes into a different flow.
Line 154: try:
Line 155: self.domain.releaseHostId(self.hostId, unused=True)
Line 156: except:
Line 157: self.log.debug("Unable to release the host id %s for
domain "
--
To view, visit http://gerrit.ovirt.org/7833
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7b2d97f95d682ea00079cee0c0587243ed56651c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Federico Simoncelli <[email protected]>
Gerrit-Reviewer: Saggi Mizrahi <[email protected]>
Gerrit-Reviewer: Yeela Kaplan <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
