Ryan Harper has posted comments on this change. Change subject: faqemu: remove the fake /dev/kvm after vdsmd stops ......................................................................
Patch Set 1: I would prefer that you didn't submit this In my testing, even if /dev/kvm as a file is present, when you load the kvm modules, it will create the correct character device needed. Please try the following on your system: (platechiller) ~ % lsmod | grep kvm kvm_intel 137721 0 kvm 415549 1 kvm_intel (platechiller) ~ % ls -al /dev/kvm crw-rw----+ 1 root kvm 10, 232 Sep 11 08:47 /dev/kvm # notice the above is a proper character device (platechiller) ~ % sudo modprobe -vr kvm_intel rmmod /lib/modules/3.2.0-29-generic/kernel/arch/x86/kvm/kvm-intel.ko rmmod /lib/modules/3.2.0-29-generic/kernel/arch/x86/kvm/kvm.ko (platechiller) ~ % ls -al /dev/kvm ls: cannot access /dev/kvm: No such file or directory (platechiller) ~ % sudo touch /dev/kvm (platechiller) ~ % ls -al /dev/kvm -rw-r--r-- 1 root root 0 Sep 11 08:48 /dev/kvm # this is just a regular file (platechiller) ~ % sudo modprobe -v kvm insmod /lib/modules/3.2.0-29-generic/kernel/arch/x86/kvm/kvm.ko (platechiller) ~ % sudo modprobe -v kvm_intel insmod /lib/modules/3.2.0-29-generic/kernel/arch/x86/kvm/kvm-intel.ko (platechiller) ~ % ls -al /dev/kvm crw-rw----+ 1 root kvm 10, 232 Sep 11 08:48 /dev/kvm # and now it's character device again note, that after loading the KVM modules while the 'fake /dev/kvm' file is present that the device file is a proper character device. -- To view, visit http://gerrit.ovirt.org/7885 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c1183acf90cd32444b1c26fa20aa843e4a0556d Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Zhou Zheng Sheng <[email protected]> Gerrit-Reviewer: Ryan Harper <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> _______________________________________________ vdsm-patches mailing list [email protected] https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
