Dan Kenigsberg has posted comments on this change.
Change subject: faqemu: remove the fake /dev/kvm after vdsmd stops
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm_hooks/faqemu/after_vdsm_stop.py
Line 22: import os
Line 23: import os.path
Line 24:
Line 25: if os.path.isfile('/dev/kvm'):
Line 26: os.unlink('/dev/kvm')
We are not going to start a VM when stopping vdsm, but still, please use the
safer
try:
os.unlink('/dev/kvm')
except OSError as e:
if e.errno != os.errno.ENOENT:
raise
--
To view, visit http://gerrit.ovirt.org/7885
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c1183acf90cd32444b1c26fa20aa843e4a0556d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
