Ryan Harper has posted comments on this change.
Change subject: faqemu: remove the fake /dev/kvm after vdsmd stops
......................................................................
Patch Set 1: (1 inline comment)
I misread the patch assuming it was removing /dev/kvm after each VM stopped,
which would have been racy. Instead the patch removes the link on vdmsd
shutdown, and then only if the file isn't a proper /dev/kvm char device; which
is the right thing to do. One other alternative is to uninstall faqemu and
have it remove it then... but I'm ok with this.
Mark, some hosts cannot provide nested KVM support, so faqemu is still quite
useful in that scenario.
Please verify the patch.
....................................................
File vdsm_hooks/faqemu/after_vdsm_stop.py
Line 19: # Refer to the README and COPYING files for full details of the license
Line 20: #
Line 21:
Line 22: import os
Line 23: import os.path
You don't need to import os.path since you are calling it from the os module.
% python2.7
Python 2.7.3 (default, Aug 1 2012, 05:14:39)
[GCC 4.6.3] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import os
>>> os.path.isfile('/dev/kvm')
False
Line 24:
Line 25: if os.path.isfile('/dev/kvm'):
--
To view, visit http://gerrit.ovirt.org/7885
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c1183acf90cd32444b1c26fa20aa843e4a0556d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
