Zhou Zheng Sheng has posted comments on this change.
Change subject: faqemu: remove the fake /dev/kvm after vdsmd stops
......................................................................
Patch Set 2: (2 inline comments)
....................................................
File vdsm_hooks/faqemu/after_vdsm_stop.py
Line 19: # Refer to the README and COPYING files for full details of the license
Line 20: #
Line 21:
Line 22: import os
Line 23: import os.path
Oops.
Line 24:
Line 25: if os.path.isfile('/dev/kvm'):
Line 26: try:
Line 27: os.unlink('/dev/kvm')
Line 21:
Line 22: import os
Line 23: import os.path
Line 24:
Line 25: if os.path.isfile('/dev/kvm'):
Sometimes the user installs the faqemu package but does not enable it in
configuration file. In this situation I do not want to delete the real
/dev/kvm, so vdsm should check if the /dev/kvm is a regular file before deletes
it.
Line 26: try:
Line 27: os.unlink('/dev/kvm')
Line 28: except OSError as e:
Line 29: if e.errno != os.errno.ENOENT:
--
To view, visit http://gerrit.ovirt.org/7885
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c1183acf90cd32444b1c26fa20aa843e4a0556d
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Zhou Zheng Sheng <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Ryan Harper <[email protected]>
Gerrit-Reviewer: Yaniv Bronhaim <[email protected]>
Gerrit-Reviewer: Zhou Zheng Sheng <[email protected]>
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
