Dan Kenigsberg has posted comments on this change.

Change subject: report cpuUser and cpuSys separately
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

....................................................
Commit Message
Line 5: CommitDate: 2012-09-19 14:51:40 +0200
Line 6: 
Line 7: report cpuUser and cpuSys separately
Line 8: 
Line 9: Uses virDomainGetCPUStats to get the CPU information instead of info()
this patch does a lot more than that. it reports guest cpu time as "user", and 
combines the other two to "sys". this, and the reasoning for this, should be 
layed out here.

did the formerly-reported cpuUser include guest cpu time?
Line 10: 
Line 11: Change-Id: I663ad25ff3ff5ce426b5159b6c9a65b7f5167605


--
To view, visit http://gerrit.ovirt.org/7718
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I663ad25ff3ff5ce426b5159b6c9a65b7f5167605
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Gal Hammer <[email protected]>
Gerrit-Reviewer: Geert Jansen <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Mark Wu <[email protected]>
Gerrit-Reviewer: Royce Lv <[email protected]>
Gerrit-Reviewer: oVirt Jenkins CI Server
_______________________________________________
vdsm-patches mailing list
[email protected]
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches

Reply via email to